Skip to content

chore(dep): upgrade go and gotd version#1079

Open
XMLHexagram wants to merge 2 commits intomasterfrom
upgrade-go-gotd
Open

chore(dep): upgrade go and gotd version#1079
XMLHexagram wants to merge 2 commits intomasterfrom
upgrade-go-gotd

Conversation

@XMLHexagram
Copy link
Copy Markdown
Collaborator

@XMLHexagram XMLHexagram commented Nov 6, 2025

close #1061

I carefully read go and gotd change logs. There don't have breaking changes.

The go version upgrade from 1.23 to 1.24 is cause by gotd upgraded the minimal go version.

@XMLHexagram XMLHexagram requested a review from iyear as a code owner November 6, 2025 18:48
@XMLHexagram XMLHexagram marked this pull request as draft November 6, 2025 20:40
@XMLHexagram
Copy link
Copy Markdown
Collaborator Author

MTProto topic api changes in this upgrade, so I rewrite related code according to

https://github.com/telegramdesktop/tdesktop/blob/cf99eef9c931b0616403ce671e74758c278ce281/Telegram/SourceFiles/data/data_forum.cpp#L157

After fix, Everything works fine. Request a review.

@XMLHexagram XMLHexagram marked this pull request as ready for review November 7, 2025 02:03
@XMLHexagram
Copy link
Copy Markdown
Collaborator Author

Maybe we should remove teamgram-server and use real telegram to run e2e task?

teamgram-server is a commercial project and public lacks maintenance...

@iyear
Copy link
Copy Markdown
Owner

iyear commented Nov 9, 2025

I migrated from the Telegram Test server to teamgram because the Test Server no longer allows the use of test phone accounts. However, teamgram’s schema layer cannot keep up with the latest versions. Before upgrading gotd, it might be better to first address the issue of test accounts

@XMLHexagram
Copy link
Copy Markdown
Collaborator Author

I migrated from the Telegram Test server to teamgram because the Test Server no longer allows the use of test phone accounts. However, teamgram’s schema layer cannot keep up with the latest versions. Before upgrading gotd, it might be better to first address the issue of test accounts

According to tdlib/td#3083, it is nearly impossible to use test server.

But goth api layer version 216 is too much higher than teamgram's 201 version.

My idea is that I can provide an unused real account for test, and we manually trigger e2e test when review PR.

@XMLHexagram XMLHexagram force-pushed the upgrade-go-gotd branch 2 times, most recently from d7fbe5f to 07c2207 Compare November 13, 2025 04:03
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Nov 14, 2025

Deploying tdl-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1d32474
Status: ✅  Deploy successful!
Preview URL: https://2a2e76e8.tdl-docs.pages.dev
Branch Preview URL: https://upgrade-go-gotd.tdl-docs.pages.dev

View logs

@XMLHexagram XMLHexagram marked this pull request as ready for review November 14, 2025 22:10
@XMLHexagram
Copy link
Copy Markdown
Collaborator Author

fix e2e test in #1094

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants