feat: shot-scraper enabled by default — universal web capture CLI#142
Draft
feat: shot-scraper enabled by default — universal web capture CLI#142
Conversation
- catalog.go: enabledByDefault: true for shot-scraper (installs on ulk install without --with-shot-scraper) - external.go: add skipIfInstalled field to ExternalModule for idempotent installs (skips if tool already in PATH) - catalog.go: set skipIfInstalled: "shot-scraper" to avoid re-running pip+Chrome download on reinstall - modules_test.go: move shot-scraper to enabled-by-default assertions - cli-tools-protocol.md: shot-scraper listed as universal standard for all web capture (replaces chrome-devtools globally) Rationale: "L'idée c'est de toujours utiliser shot-scraper" — required for visual-auditor (03), frontend-qa (02), seo-auditor (32), agamotto (17) and any future web capture need. https://claude.ai/code/session_017e5NQNe53RbzGuV5Cwq5ug
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
catalog.go:enabledByDefault: true— shot-scraper installs onulk installwithout--with-shot-scraperexternal.go: newskipIfInstalledfield onExternalModule— idempotent installs (skips pip+Chrome download if tool already in PATH)modules_test.go: shot-scraper moved to enabled-by-default assertionscli-tools-protocol.md: shot-scraper listed as universal standard for all web capture (replacesmcp__chrome-devtools__*globally)Rationale
"L'idée c'est de toujours utiliser shot-scraper" — required for visual-auditor (03), frontend-qa (02), seo-auditor (32), agamotto (17) and any future web capture task. No more opt-in flag needed.
The
skipIfInstalledfield also prevents re-running the heavy pip+Playwright Chrome download on reinstall when shot-scraper is already available.Test plan
go test ./...— all packages passTestDefaultModules— shot-scraper asserted as enabled by defaultTestInstallerCopiesCommands— no longer tries to download Chrome (idempotent skip)TestAllModulesWellFormed— structural validation passeshttps://claude.ai/code/session_017e5NQNe53RbzGuV5Cwq5ug
Generated by Claude Code