ci(go): fix coverage gate by instrumenting all packages with -coverpkg#157
Merged
ci(go): fix coverage gate by instrumenting all packages with -coverpkg#157
Conversation
The Go coverage gate used `go test -coverprofile=coverage.out ./...` without `-coverpkg=./...`. Each package only measured its own statements; cross-package execution (cmd integration tests driving internal/*) was never attributed, and packages without tests were absent from the profile entirely. The 70% threshold was passing on artificially inflated per-package self-coverage. Add `-coverpkg=./...` so every package is instrumented and cross-package usage is properly counted. Real coverage surfaces at ~38.8% — drop the threshold to 35% so the gate is honest and still acts as a regression guard. Also drop the `2>/dev/null` redirect that was hiding test stderr. https://claude.ai/code/session_016UwwMWsDgFY16GHiEAwuvu
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/test.ymlrango test -coverprofile=coverage.out ./...without-coverpkg=./.... Each package's profile only tracked its own statements; cross-package execution (e.g.cmdintegration tests drivinginternal/installer,internal/registry,tui) was never attributed, and packages without their own tests were absent from the profile entirely. The 70% threshold was passing on artificially inflated per-package self-coverage.-coverpkg=./...so every package is instrumented on every test run and cross-package usage is properly counted.2>/dev/nullthat was hidinggo teststderr.Test plan
go test -coverpkg=./... -coverprofile=coverage.out ./...locally → all package tests pass.go tool cover -func=coverage.out | tail -1→total: (statements) 38.8%.pct=38; [ "$pct" -lt 35 ]→ false) → gate passes.ubuntu-latestandmacos-latest.https://claude.ai/code/session_016UwwMWsDgFY16GHiEAwuvu
Generated by Claude Code