Fix nested brace handling in LaTeX definition parser#102
Merged
izzortsi merged 2 commits intofeature/automated-semantic-analysisfrom Nov 14, 2025
Merged
Fix nested brace handling in LaTeX definition parser#102izzortsi merged 2 commits intofeature/automated-semantic-analysisfrom
izzortsi merged 2 commits intofeature/automated-semantic-analysisfrom
Conversation
Co-authored-by: izzortsi <35747979+izzortsi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on automated semantic analysis workflow
Fix nested brace handling in LaTeX definition parser
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regex pattern
r'\\definition\{([^}]+)\}\{([^}]+)\}'fails on nested braces, stopping at the first}encountered. This breaks parsing of definitions like\definition{term}{text with \emph{nested} braces}.Changes
_extract_latex_arg()method using depth-counting algorithm to properly match braces_extract_definitions()to use the parser instead of regex\\{,\\}) correctlyExample
The parser tracks brace depth and only terminates when depth returns to zero, ensuring all nested structures are captured.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.