Skip to content

Add error handling for empty concept generation in automated workflow#99

Merged
izzortsi merged 2 commits intofeature/automated-semantic-analysisfrom
copilot/sub-pr-79
Nov 14, 2025
Merged

Add error handling for empty concept generation in automated workflow#99
izzortsi merged 2 commits intofeature/automated-semantic-analysisfrom
copilot/sub-pr-79

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Nov 14, 2025

Addresses review feedback from #79: the commit step didn't handle cases where all concepts are filtered as "weak", potentially causing silent failures.

Changes

Added explicit check for staged changes before commit:

git add knowledge-database/concepts
if git diff --cached --quiet; then
  echo "⚠️ No concept files generated"
  exit 1
fi
git commit -m "..."

The workflow now fails fast with a clear error message when no concepts are generated, rather than continuing with undefined behavior.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: izzortsi <35747979+izzortsi@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback from review on automated semantic analysis workflow Add error handling for empty concept generation in automated workflow Nov 14, 2025
Copilot AI requested a review from izzortsi November 14, 2025 00:57
@izzortsi izzortsi marked this pull request as ready for review November 14, 2025 00:59
@izzortsi izzortsi merged commit 514a125 into feature/automated-semantic-analysis Nov 14, 2025
@izzortsi izzortsi deleted the copilot/sub-pr-79 branch November 14, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants