Skip to content

Crash - Few bugs fix #110

Open
A-Julien wants to merge 3 commits intoj-holub:masterfrom
A-Julien:master
Open

Crash - Few bugs fix #110
A-Julien wants to merge 3 commits intoj-holub:masterfrom
A-Julien:master

Conversation

@A-Julien
Copy link

Hello,

I suggest these few bugs fix :

  • Avoid error when ipcRequests doese not exist in the request array (lib/ipcInterface/_events.js)
  • Fix crash when mpv restart or when the socket is closed
  • Ensure that the socket is writable before write in send() function

Voila! I don't know if I made all the changes in the right way, so feel free to correct me;

@an-lee
Copy link

an-lee commented May 8, 2023

I truly hope this PR can be merged. @j-holub

@daerup
Copy link

daerup commented Jun 14, 2023

@j-holub Please look into this, it looks promising!

@j-holub
Copy link
Owner

j-holub commented Jan 16, 2025

Hi guys,

sorry have been absent from GitHub for quite a while. I will look into this. Thanks for coming up with the fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants