Skip to content

Stop checking for only http#92

Open
NolanCassidy wants to merge 1 commit intoj-holub:Node-MPV-2from
NolanCassidy:patch-2
Open

Stop checking for only http#92
NolanCassidy wants to merge 1 commit intoj-holub:Node-MPV-2from
NolanCassidy:patch-2

Conversation

@NolanCassidy
Copy link
Contributor

No description provided.

@j-holub
Copy link
Owner

j-holub commented Jul 17, 2021

Where's the part, where file paths are transformed to absolute paths, such that it works, no matter from which path Node-MPV was started?
I get that checking for HTTP only might not be the best idea and it needs to be changed, but removing the transformation to absolute paths for file paths is not the way to do this in my opinion.

Furthermore, if you delete a line of code, might as well delete the 3-line comment that explains what it does : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants