add tag exclusion to relative filter generation #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riccardoleder
requested review from
garethj2,
gretadj2,
hecsalazarf,
jaxgzz,
kianj2 and
thoughtpalette
Contributor
|
LGTM 🎉 |
thoughtpalette
approved these changes
Sep 30, 2025
kianj2
approved these changes
Sep 30, 2025
gretadj2
approved these changes
Sep 30, 2025
Contributor
gretadj2
left a comment
gretadj2
left a comment
There was a problem hiding this comment.
Just a small annotation, but LGTM!
src/filter/util.ts
Outdated
| 'hisCollectCOV', | ||
| 'hisCollectNA', | ||
| 'hisTotalized', | ||
| 'haystackPoint', |
Contributor
There was a problem hiding this comment.
I guess this is not meant to be comprehensive, but since you have already added bacnetPoint and haystackPoint, why not adding modbusPoint too? We could probably cover 90% of the cases with these 3 connectors ;)
Contributor
|
As already discussed with Riccardo, we need to pass in an optional namespace that can be used to look up all connPoint tags so they can be excluded. |
Contributor
Author
|
@garethj2 I updated the implementation to reflect the changes we discussed about. Please let me know if you think this requires additional changes. |
Contributor
|
LGTM |
garethj2
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to provide a list of tags that will be excluded from the relative filter generation.
This can be useful when certain marker tags need to be avoided as they are not really part of what makes the relative filter relevant and would only restrict the filter usefulness.