Fix CFString null pointer crash during keyboard layout initialization #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #19 When skhd initializes, it queries the macOS keyboard layout to build a mapping of keys to keycodes. On certain keyboard layouts, CFStringCreateWithCharacters can return NULL for some keycodes, but the code wasn't checking for this before attempting to copy the CFString. This commit adds a null check that: - Detects when CFString creation fails - Logs the failure as an error - Skips the problematic keycode and continues initialization - Uses the unwrapped value when confirmed non-null This prevents the "Failed to copy CFString" error that was preventing skhd from starting on some systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Failed to copy CFString#19 - "Cannot start, I keep gettingFailed to copy CFString"CFStringCreateWithCharactersreturn valueRoot Cause
When skhd initializes, it queries the macOS keyboard layout to build a mapping of keys to keycodes. On certain keyboard layouts,
CFStringCreateWithCharacterscan return NULL for some keycodes, but the code wasn't checking for this before attempting to copy the CFString. This caused a crash during initialization.Changes
src/Keycodes.zig:202-205key_cfstring.?when confirmed non-nullTest Plan
zig build test)zig build -Doptimize=ReleaseFast)