RFC: scan findings lifecycle API prototype#121
Draft
MTG-Thomas wants to merge 1 commit intojackmusick:mainfrom
Draft
RFC: scan findings lifecycle API prototype#121MTG-Thomas wants to merge 1 commit intojackmusick:mainfrom
MTG-Thomas wants to merge 1 commit intojackmusick:mainfrom
Conversation
Frame the recovered Nuclei ingestion work as a platform RFC for recurring external scan findings lifecycle management.\n\nThis keeps the implementation intentionally small: an admin-only FastAPI router backed by existing org-scoped table documents, with run tracking, ingest, filtering, re-alert suppression, resolve-on-absence, and bulk state transitions.\n\nThe current concrete producer is Nuclei, but the upstream discussion should decide whether this belongs as-is, should be generalized before merge, or should remain workspace-specific.
|
|
||
|
|
||
| def _stable_id(raw: str) -> str: | ||
| return hashlib.sha1(raw.encode("utf-8")).hexdigest() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC framing
This is a draft PR attached to #120. Please treat it as a concrete RFC prototype, not a ready-to-merge feature request.
The question for upstream is whether Bifrost should own a small lifecycle primitive for recurring external scan/security observations, or whether this kind of behavior should remain entirely in downstream workspace code.
What this prototype does
/api/scans/*router for scan runs and findings.What this is not
Design questions for maintainers
nuclei_scansto a broaderscanner_findingsorsecurity_findingsAPI before merge?Validation
python -m compileall api/src/routers/nuclei_scans.py api/src/main.py api/src/routers/__init__.py/api/scans/*python -m pytest api/tests/unit/test_nuclei_scans_router.py -qpython -m ruff check api/src/routers/nuclei_scans.py api/src/main.py api/src/routers/__init__.py api/tests/unit/test_nuclei_scans_router.pygit diff --checkNote: broad
python -m pytest api/tests/unit -qcurrently stops during collection on Windows because existing process-pool tests import Unix-onlyresource; that occurs before this Nuclei test module runs.