Fix: HTTP 500 errors, duplicate paths, and WSL platform selection (#37, #36, #26)#45
Open
vanmarkic wants to merge 6 commits intojacksteamdev:mainfrom
Open
Fix: HTTP 500 errors, duplicate paths, and WSL platform selection (#37, #36, #26)#45vanmarkic wants to merge 6 commits intojacksteamdev:mainfrom
vanmarkic wants to merge 6 commits intojacksteamdev:mainfrom
Conversation
…v#37) - Add normalizeDirectory utility to strip trailing slashes from paths - Update list_vault_files to use normalized paths - Prevents HTTP 500 errors when directory parameter has trailing slash - Add comprehensive tests for path normalization Fixes jacksteamdev#37
- Add normalizeDuplicateSegments utility to detect and remove repeating path patterns - Apply normalization to resolved install paths after symlink resolution - Fixes issue where paths like /home/user/home/user/vault were created - Particularly helpful for symlinked home directories - Add comprehensive tests for duplicate path detection Fixes jacksteamdev#36
…amdev#26) - Add settings for custom platform, architecture, binary path, command, env vars, and host - Allow users to override detected platform/arch (useful for WSL scenarios) - Support custom command wrapper (e.g., wsl.exe for running Linux binary from Windows) - Add custom environment variables and host configuration - Update install and config services to respect custom settings - Add tests for platform/architecture override functionality Example use case: Run Obsidian on Windows but use Linux MCP server in WSL - Set customPlatform: "linux" - Set customCommand: "wsl.exe --distribution Ubuntu -- bash -c \"mcp-server-bin\"" - Set customEnvVars and customHost as needed Implements jacksteamdev#26
- Document duplicate path normalization in symlink resolution - Add Custom Configuration section with WSL example - Document platform/arch override, custom commands, and env vars - Mark custom binary locations as implemented in Future Considerations
✅ Deploy Preview for superb-starlight-b5acb5 canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses three critical issues in the MCP server installation process:
✅ Fix #37: HTTP 500 errors caused by trailing slashes in directory paths
✅ Fix #36: Duplicate path segments in installation paths
✅ Fix #26: Platform and architecture selection for WSL users
Changes
1. Trailing Slash Bug Fix (#37)
getVaultPath()andinstallMcpServer()2. Duplicate Path Segments Fix (#36)
getInstallPath()3. WSL Platform Selection (#26)
Testing
✅ 19 unit tests added (all passing)
Documentation
mcp-server-install.mdwith new featuresMigration Notes
No breaking changes. All fixes are backward compatible.
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com