fix: use JSON.stringify for safe JS string interpolation in evaluate()#109
Merged
jackwener merged 1 commit intojackwener:mainfrom Mar 20, 2026
Merged
fix: use JSON.stringify for safe JS string interpolation in evaluate()#109jackwener merged 1 commit intojackwener:mainfrom
jackwener merged 1 commit intojackwener:mainfrom
Conversation
Replace ad-hoc string escaping with JSON.stringify() for values interpolated into JavaScript code strings passed to page.evaluate(). - explore.ts: clickLabels were escaped with only single-quote replacement, which breaks on labels containing backslashes or newlines. JSON.stringify() handles all edge cases correctly. - synthesize.ts: buildEvaluateScript() embedded URLs directly inside single quotes. JSON.stringify() safely handles URLs containing special characters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace ad-hoc string escaping with JSON.stringify() for values interpolated into JavaScript code strings passed to page.evaluate().
explore.ts: clickLabels were escaped with only single-quote replacement, which breaks on labels containing backslashes or newlines. JSON.stringify() handles all edge cases correctly.
synthesize.ts: buildEvaluateScript() embedded URLs directly inside single quotes. JSON.stringify() safely handles URLs containing special characters.
Related issue:
Type of Change
Checklist
Screenshots / Output