fix(main): navigate to domain before cookie/header strategy commands#70
Closed
backtime1993 wants to merge 1 commit intojackwener:mainfrom
Closed
fix(main): navigate to domain before cookie/header strategy commands#70backtime1993 wants to merge 1 commit intojackwener:mainfrom
backtime1993 wants to merge 1 commit intojackwener:mainfrom
Conversation
… commands When a cookie/header strategy command runs, the browser page may be on an unrelated domain (e.g. YouTube tab active while running `bilibili search`). The in-page `fetch()` with `credentials: 'include'` then fails because the browser blocks cross-origin credentialed requests. Fix: before executing cookie/header strategy commands, navigate to the command's declared `domain` so the fetch runs in same-origin context. This mirrors the pre-navigation already done in `cascade` command. Fixes intermittent "Failed to fetch" errors for all cookie-strategy adapters (bilibili, twitter, zhihu, xueqiu, etc.) when the active Chrome tab is on a different site. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Closing this — after further investigation, this issue only occurs with CDP auto-discovery mode (not yet upstream). The fix belongs in the chrome-auto-discovery feature branch instead. Sorry for the noise! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bilibili search,twitter timeline,zhihu hot) fail withFailed to fetchwhen the active Chrome tab is on an unrelated domainfetch()withcredentials: 'include'is executed in-page, but cross-origin credentialed requests are blocked by the browser's same-origin policycmd.domainbefore executing cookie/header strategy commands, mirroring the pre-navigation already done in thecascadecommandRepro
opencli bilibili search --keyword "test"Error: Failed to fetchAfter fix: opencli automatically navigates to
bilibili.comfirst, then runs the API fetch in same-origin context.Changes
src/main.ts: Add domain pre-navigation forStrategy.COOKIEandStrategy.HEADERcommands before executing the command functionStrategyenum from registryTest plan
bilibili searchworks regardless of active Chrome tabbilibili hot(public strategy, no cookie) still worksyoutube search(cookie strategy) still workstsc --noEmit)🤖 Generated with Claude Code