Conversation
…continuous integration.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 728ceb4f12
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| branches: [ "master" ] | ||
| pull_request: | ||
| branches: [ "master" ] |
There was a problem hiding this comment.
Point CI triggers at the branch used for development
This workflow is restricted to master for both push and pull_request, so in environments where development happens on main (as in this repository’s refs), the test job will not run at all and regressions can merge without validation. Please align these branch filters with the actual default/integration branch so CI executes on normal PR and push flows.
Useful? React with 👍 / 👎.
| ext_filter = CONFIG.get('EXT_FILTER', []) | ||
| if ext_filter: | ||
| _, ext = os.path.splitext(file_path) | ||
| if ext.lower() not in ext_filter: |
There was a problem hiding this comment.
Normalize extension filters before membership checks
should_exclude lowercases the file extension (ext.lower()) but compares it against raw EXT_FILTER values from JSON, so a user-provided entry like .JPG will never match and intended files get skipped from auditing. This is a behavior regression from the previous loader, which normalized extension entries to lowercase, and it can silently drop protected file types when users customize the config.
Useful? React with 👍 / 👎.
No description provided.