Update lxml to Enhance Compatibility and Stability#255
Open
rybrennan wants to merge 1 commit intojaebradley:v4from
Open
Update lxml to Enhance Compatibility and Stability#255rybrennan wants to merge 1 commit intojaebradley:v4from
rybrennan wants to merge 1 commit intojaebradley:v4from
Conversation
Upgraded lxml from 4.5.1 to resolve build and compatibility issues with newer Python versions and system libraries. This ensures the project's stability and functionality across environments, preserving its ability to accurately scrape basketball reference data. - Updated `lxml` in `pyproject.toml` to a newer, compatible version. - Confirmed successful builds and unchanged functionality post-update. - Enhanced compatibility with recent Python and system dependencies.
jaebradley
reviewed
Mar 27, 2024
| chardet = "==3.0.4" | ||
| idna = "==2.7" | ||
| lxml = "==4.5.1" | ||
| lxml = "^4.6.3" |
Owner
There was a problem hiding this comment.
PR #250 increased the version of lxml to ^4.9.1. So this change would be a lxml version downgrade - feel free to bump the lxml version to a more recent version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgraded lxml from 4.5.1 to resolve build and compatibility issues with newer Python versions and system libraries. This ensures the project's stability and functionality across environments, preserving its ability to accurately scrape basketball reference data.
lxmlinpyproject.tomlto a newer, compatible version.