Open
Conversation
jaebradley
requested changes
Nov 20, 2024
Owner
jaebradley
left a comment
jaebradley
left a comment
There was a problem hiding this comment.
@JasonHo420 apologies for the delayed review!
Thanks for opening this PR to add more information to the README file.
My preference is to move as much information as possible to the documentation site (https://jaebradley.github.io/basketball_reference_web_scraper/).
You can see the content for the documentation site in the docs folder (like https://github.com/jaebradley/basketball_reference_web_scraper/blob/v4/docs/index.md).
I think we can condense the information here into additional content contained within docs/index.md - does that seem reasonable?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an Introduction and a Background that describes what basketball reference is.