Fix case-sensitive search in PDF term matching#3
Open
rootdevss wants to merge 1 commit intojafrank88:mainfrom
Open
Fix case-sensitive search in PDF term matching#3rootdevss wants to merge 1 commit intojafrank88:mainfrom
rootdevss wants to merge 1 commit intojafrank88:mainfrom
Conversation
The previous implementation used case-sensitive string matching, which could miss valid matches when the case differed between the search term and the PDF content. This is particularly problematic for legal citations which may appear in various case formats (e.g., 'F.3d' vs 'f.3d', 'Singh-Kaur' vs 'singh-kaur'). This commit makes the search case-insensitive by converting both the search term and the extracted text to lowercase before comparison, ensuring all valid matches are found regardless of case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a bug in the PDF search functionality where term matching was case-sensitive, potentially causing valid matches to be missed.
Problem
The current implementation in
check_pdf.pyuses case-sensitive string comparison:This causes the search to fail when the case differs between the search term and the PDF content. For a tool designed to identify legal citations, this is particularly problematic because:
F.3dvsf.3d)Singh-Kaurvssingh-kaurvsSINGH-KAUR)Solution
Implemented case-insensitive string matching by converting both the search term and extracted text to lowercase before comparison:
Additionally updated the context extraction logic to use the same case-insensitive approach when finding the position of matches:
Testing Recommendation
To verify this fix works correctly, test with PDFs containing:
Impact
This change ensures that all legitimate matches are found regardless of case formatting, improving the reliability and accuracy of the hallucination detection tool.
Type of Change