Verify Jsonb calls close methods #351
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
struberg
approved these changes
Oct 20, 2024
mkarg
approved these changes
Dec 23, 2024
|
@jakartaee/ee4j-jsonb-committers Kindly asking to review this PR. |
The stream based methods in Jsonb specify close being called upon successful completion. Add tests that verify an implementation calls these methods.
marschall
force-pushed
the
test-call-close
branch
from
946d548 to
a3c85ec
Compare
mkarg
reviewed
Dec 27, 2024
tck/src/main/java/ee/jakarta/tck/json/bind/api/jsonb/JsonbTest.java
Outdated
Show resolved
Hide resolved
| return closeCalled; | ||
| } | ||
|
|
||
| byte[] toByteArray() { |
There was a problem hiding this comment.
Can't do that #toByteArray() is defined on ByteArrayOutputStream not on OutputStream.
tck/src/main/java/ee/jakarta/tck/json/bind/api/jsonb/JsonbTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stream based methods in Jsonb specify close being called upon successful completion. Add tests that verify an implementation calls these methods.