[#191] using term unchecked exception instead of RuntimeException for rollback for CDI interceptor#192
Open
ochaloup wants to merge 1 commit intojakartaee:masterfrom
Conversation
Contributor
|
Can one of the admins verify this patch? |
Contributor
|
OK to test |
Contributor
|
@ochaloup would it result in changes to the TCK? If not, can a TCK test be proposed? |
d32e34d to
05e4197
Compare
Contributor
|
@ochaloup as you may have seen over at https://www.eclipse.org/lists/jta-dev/msg00198.html I have raised the topic with the community. I would ask, should the change was agreed, would you be willing to create a TCK test that can be used to verify implementations are compliant with the change? The test would be to:
This might be the place that the test could be added to should the change be agreed: https://github.com/eclipse-ee4j/jakartaee-tck/tree/master/src/com/sun/ts/tests/jta/ee/transactional |
…ption for rollback for CDI interceptor Signed-off-by: Ondra Chaloupka <ochaloup@redhat.com>
05e4197 to
38ba038
Compare
Author
|
@tomjenkinson sure, I know. I will try to create the tests in TCK. |
Contributor
|
retest this please |
1 similar comment
Contributor
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #191