Clarify when the readOnly value goes into effect#243
Open
njr-11 wants to merge 1 commit intojakartaee:masterfrom
Open
Clarify when the readOnly value goes into effect#243njr-11 wants to merge 1 commit intojakartaee:masterfrom
njr-11 wants to merge 1 commit intojakartaee:masterfrom
Conversation
Contributor
|
Can one of the admins verify this patch? |
Contributor
|
OK to test |
Contributor
|
It looks very useful to me - thank you, @njr-11. I am going to approve it. We might as well let CI run on it (CI might build the spec doc and spot something) but I expect we can merge it soon. Thank you again |
Contributor
|
Sorry, it should build the Javadoc, which is where the change is :) |
tomjenkinson
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing #222 in order to learn about how this will integrate with the Jakarta Connector specification, I noticed ambiguous wording in the
setReadOnlymethod Javadoc that makes it unclear whether the new read-only applies to a transaction that was just started on the thread or only to subsequent transactions that are started after that point. I posted a comment to the PR. The author replied to point out that the intended meaning is the latter, but indicated he had copied the pattern for the wording from thesetTransactionTimeoutmethod and would not be updating it under the PR (which was impossible anyway because the PR was already merged). Another participant asked me to submit a PR with proposed unambiguous wording for the methods. That is attempted under this PR.