Actually cancel the set alarms and intents#22
Open
Forceh91 wants to merge 9 commits intojakebonk:masterfrom
Open
Actually cancel the set alarms and intents#22Forceh91 wants to merge 9 commits intojakebonk:masterfrom
Forceh91 wants to merge 9 commits intojakebonk:masterfrom
Conversation
If nothing was found in the cursor when attempting to do a cancel it would error out and never close the database, causing further errors down the line.
We need to check that data.moveToFirst exists before we try and fetch info from it. Otherwise the NotificaitonPublisher does not handle itself well and crashes (possibly?) causing more issues down the line.
Fix database close issues on cancel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.