Merged
Conversation
- Replace default fade-out with elegant slide-down animation using translateY(100%) - Implement dual auto-hide triggers: cursor leave + inactivity detection - Add spring easing (cubic-bezier) for natural, bouncy motion - Maintain control bar visibility when video is paused - Prevent phantom clicks with pointer-events: none when hidden - semi-transparent background (rgba(0,0,0,0.5)) for clean look
- fix the sliding down animation where the control bar would slide down to the buttons, titles. - Added css variables to make it easier to mess with transition times
- now control bar always stays when paused.
Contributor
Author
|
@jakemiki is this good? to be merged or do you want anything changed? |
Owner
|
Looks good, thanks for your contribution! Sorry I took so long to get around to review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.