Provide context to 'action' function. Clean up DOM on destroy#6
Open
cwacek wants to merge 2 commits intojakiestfu:masterfrom
Open
Provide context to 'action' function. Clean up DOM on destroy#6cwacek wants to merge 2 commits intojakiestfu:masterfrom
cwacek wants to merge 2 commits intojakiestfu:masterfrom
Conversation
'action' functions will now receive the DOM element that was right-clicked to create the context menu as their second argument.
|
👍 |
|
cwacek@e79050b doesn't work when you've got multiple menu items, as you're creating a function in a loop. A quick n' dirty workaround for this is to wrap it up in an IFFE, so it will bind the declared variables correctly. Lines 73-83: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #2 by providing 'action' functions with the DOM element that was right-clicked as their second argument.
It also fixes #1 by removing context menus from the DOM on destroy.