Skip to content

Comments

adds how-to for using a powershell profile#20

Open
1d3s wants to merge 1 commit intojakkn:masterfrom
1d3s:patch-1
Open

adds how-to for using a powershell profile#20
1d3s wants to merge 1 commit intojakkn:masterfrom
1d3s:patch-1

Conversation

@1d3s
Copy link

@1d3s 1d3s commented Oct 5, 2018

No description provided.

@jakkn
Copy link
Owner

jakkn commented Oct 7, 2018

Hi, thank you for the PR!

I've tried following the instructions on my system but the mount path fails to expand correctly in the docker-toolbox environment. The colon printed by pwd (C:/myPath) is interpreted as a delimiter and the command fails (ref: #12590, #12751). That's a shortcoming of the function though, and not related to actually setting the function in the profile. I assume you're running without toolbox if this works on your end?

It would be good to document a warning regarding toolbox behavior, suggesting to use the Linux approach instead which will work under the toolbox environment.

And I have one nitpicking; If you look at git log --oneline you'll notice that all commit subjects are written in the imperative mood (see this blog post by chris beams for reasons). In an effort to keep the commit history consistent it would be great if adds changed to Add, so that the subject reads Add how-to for using a powershell profile. If this is the latest commit you have locally then git commit --amend should be enough, otherwise use git rebase -i 99c401. Then force push to your branch to update the PR.

@jakkn
Copy link
Owner

jakkn commented Nov 26, 2018

@1d3s any interest in updating the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants