Open
Conversation
jakkn
requested changes
Mar 26, 2019
Owner
jakkn
left a comment
jakkn
left a comment
There was a problem hiding this comment.
Hi, thank you for the PR. It took me a while to go over everything as there is a lot to cover. It is very important to me that the documentation is clear and not confusing, to the point, and correct. It is not my intention to give unreasonable critique, I appreciate your effort and have tried to be objective and constructive in my feedback. Please let me know if you disagree with anything.
jakkn
requested changes
Mar 31, 2019
Owner
jakkn
left a comment
jakkn
left a comment
There was a problem hiding this comment.
Thank you for the changes. I only found a couple more things to address, then we'll merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From issue #26.
The guide is not finish. I'm stilling working in the Docker part.
Following this Guide I've completed the whole process from installation to unpack and pack again in Windows 10 with NWN:EE installed.
If you are agree I will write guides for Linux (Debian/Ubuntu) and OSX.