Skip to content

fix(views): remove unused defaultModel declaration in model-picker#2

Merged
james-heidi merged 8 commits intomainfrom
fix/model-picker-unused-default-model
Apr 29, 2026
Merged

fix(views): remove unused defaultModel declaration in model-picker#2
james-heidi merged 8 commits intomainfrom
fix/model-picker-unused-default-model

Conversation

@james-heidi
Copy link
Copy Markdown
Owner

Summary

Mirror of upstream fix PR multica-ai#1884. Removes a now-unused defaultModel useMemo in packages/views/agents/components/inspector/model-picker.tsx that was orphaned when commit 55b7e2e (upstream PR multica-ai#1875) dropped its only consumer. Without this fix, tsc --noEmit on the merged tree fails with TS6133: 'defaultModel' is declared but its value is never read.

This is the same one-line fix in both repos so the fork stays consistent with upstream.

Test plan

Notes

🤖 Generated with Claude Code

forrestchang and others added 8 commits April 29, 2026 13:48
…ultica-ai#1864)

Without this guard, submitting during an active upload causes
stripBlobUrls to silently remove the in-flight blob image from the
markdown, so the agent never sees the pasted screenshot. Now the Create
button disables and shows "Uploading…" until all file uploads resolve.
…ultica-ai#1866)

The agent-mode Quick Capture dialog already supported image paste and
drag-drop through the ContentEditor, but lacked a visible file
attachment button. This made the feature undiscoverable.

Add a FileUploadButton (paperclip icon) to the footer, matching the
pattern already used by the manual create panel and comment input.
…form (multica-ai#1862)

* feat(ui): make New Issue button open Quick Capture instead of manual form

The sidebar "New Issue" button and the search command's "New Issue" action
now open the agent-based Quick Capture dialog directly, matching the
platform's agent-first workflow.

Contextual issue creation (board columns, list view status groups, sub-issues)
still opens the manual form since those pass pre-filled data.

Closes MUL-1558

* test(search): update search-command test to expect quick-create-issue

Aligns the test assertion with the behavior change in the previous
commit where "New Issue" now opens Quick Capture.
…ion (multica-ai#1872)

The issue detail page breadcrumb showed both the issue identifier and
title (e.g. "MUL-1567 Title"), making the ID appear twice. Remove the
standalone identifier span so only the title is displayed.
…minently (multica-ai#1873)

The inbox notification for quick-create showed "Created MUL-1577: <title>"
which truncated the actual issue title. Now the title field shows just the
issue title (the most useful info), and the detail label shows "Created
MUL-XXXX" as context.
* feat(views): keep quick capture open after submit for continuous creation

After successfully sending a prompt to the agent, the dialog now clears
the editor and stays open instead of closing. This lets users create
multiple issues in quick succession without reopening the dialog each
time. The user can still close manually via X or Escape.

* feat(views): add success feedback for quick capture continuous mode

After each successful submit, the Create button briefly flashes green
with a checkmark "✓ Sent" for 1.5s, then reverts. A persistent counter
("N sent") appears in the footer so the user knows how many prompts
they've dispatched in this session. No explicit mode toggle needed —
the counter implicitly signals continuous mode is active.

* feat(views): add "Create another" toggle to quick capture (Linear-style)

Replace always-on continuous mode with an opt-in toggle switch in the
footer, matching Linear's "Create more" pattern. The preference is
persisted per-workspace via the quick-create store so it remembers
across sessions.

- Toggle OFF (default): submit closes the dialog (original behavior)
- Toggle ON: submit clears the editor and stays open; button flashes
  green "✓ Sent" and a counter shows how many have been dispatched

* fix(views): remove stale breadcrumb identifier test

PR multica-ai#1872 removed the issue identifier from the breadcrumb but the
corresponding test was not updated, causing CI to fail.
multica-ai#1875)

When no model is explicitly selected, the model dropdown and inspector
picker no longer show "Default — Claude Sonnet 4.6". Instead they show
"Default (provider)" / "Default", avoiding confusion when the actual
CLI default differs from the hardcoded catalog entry.
Commit 55b7e2e dropped the only consumer of `defaultModel` (the
`triggerLabel` expression) but left the `useMemo` declaration in
place, which fails `tsc --noEmit` with TS6133 and red-CI's any
downstream branch.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@james-heidi james-heidi merged commit 4b79576 into main Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants