fix: resolve data race, hardcoded exchange, and channel churn#6
Merged
fix: resolve data race, hardcoded exchange, and channel churn#6
Conversation
…t package - Consumer: use GetConnection() instead of direct connManager.conn access in listenOnce() to prevent data race during reconnection - Emitter: remove hardcoded "logs_topic" exchange declaration from setup(); exchanges are now declared per-Publish() call where the name is known - Emitter: reuse a persistent AMQP channel instead of opening/closing one per Publish() call; channel auto-recreates on failure with mutex protection - Remove unused getExchangeName() helper Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
listenOnce()accessedconnManager.conndirectly without mutex protection (line 216). During reconnection, thereconnect()goroutine setsconn = nilunder lock, causing a nil pointer panic. Fixed by usingGetConnection()which acquiresRLock.setup()declared"logs_topic"exchange regardless of what exchange name is passed toPublish(). Removed — exchange declaration now happens inPublish()where the actual name is known.Publish()opened and closed a new AMQP channel on every call, causing unnecessary overhead under load. Replaced with a persistent channel (mutex-protected) that auto-recreates on failure. Exchange declarations are cached per channel lifetime.Test plan
go build ./...compilesgo test ./...passes (lib/event tests)GetConnection()for NotifyClose🤖 Generated with Claude Code