Skip to content

Conversation

@jameslong
Copy link
Owner

This pull request refactors request-building functions in the Vancouver codebase to improve naming consistency and clarity. The changes include renaming methods and updating their references across the codebase.

Refactoring of request-building functions:

  • Renamed build_request/2 to build_get_request/2 in lib/vancouver/test/prompt_test.ex and updated its references in test/vancouver/test/prompt_test.exs to reflect the new name. [1] [2]
  • Renamed call_request/2 to build_call_request/2 in lib/vancouver/test/tool_test.ex and updated its references in test/vancouver/test/tool_test.exs, test/vancouver/tools/calculate_sum_test.exs, and test/vancouver/tools/test_response_test.exs. [1] [2] [3] [4] [5]

@jameslong jameslong self-assigned this Jun 17, 2025
@jameslong jameslong requested a review from Copilot June 17, 2025 15:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors request-building functions in the Vancouver codebase for improved naming consistency and clarity.

  • Renamed build_request/2 to build_get_request/2 and updated relevant tests.
  • Renamed call_request/2 to build_call_request/2 with corresponding changes in both tests and library code.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/vancouver/tools/test_response_test.exs Updated function call from call_request to build_call_request.
test/vancouver/tools/calculate_sum_test.exs Corrected function call reference from call_request to build_call_request.
test/vancouver/test/tool_test.exs Updated describe block and assertions to refer to build_call_request.
test/vancouver/test/prompt_test.exs Updated describe block and assertions to refer to build_get_request.
lib/vancouver/test/tool_test.ex Replaced call_request with build_call_request along with updated docs.
lib/vancouver/test/prompt_test.ex Renamed build_request to build_get_request with updated spec and docs.

@jameslong jameslong merged commit 5e1a985 into main Jun 17, 2025
1 check passed
@jameslong jameslong deleted the build_request_consistency branch June 17, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants