Fix/issue 193 editor tab close crash #218
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DOM conflicts Monaco moves contentWidget DOM nodes to its overlay container. When React tries to unmount these nodes, they're no longer in their expected location, causing 'removeChild' errors. This fix creates the widget container via document.createElement() and uses React portals to render content into it. Fixes jamesmurdza#193
… DOM conflicts Apply the same fix pattern to GenerateWidget - create anchor and widget containers via document.createElement() and use React portals to render content. This prevents Monaco from causing DOM node conflicts when the editor tab is closed. Related to jamesmurdza#193
- Add suggestionWidgetRef to store widget instance for proper cleanup - Add cleanup return to suggestion widget useEffect - Add cleanup return to generate widget useEffect - Add cleanupWidgets function for manual widget cleanup - Update refs to MutableRefObject for imperative container assignment Related to jamesmurdza#193
Call cleanupWidgets and reset widget states (isSelected, generate.show) before removing the tab to ensure Monaco widgets are properly disposed before React unmounts the component. Related to jamesmurdza#193
|
@Code-Victor is attempting to deploy a commit to the jamesmurdza's projects Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Prevent App Crash When Closing Editor Tab with Selection
Closes #193
Closes #181
Problem
The app crashes with a
Failed to execute 'removeChild' on 'Node'error when closing an editor tab that has a text selection. This happens because Monaco'saddContentWidgetmoves React-managed DOM nodes to its overlay container. When the tab closes, React tries to unmount nodes that are no longer in their expected location.Solution
Create widget containers imperatively (outside of React's DOM tree) using
document.createElement(), and render content into them using React portals. This way:Changes
createPortaluseEffectcleanup returnsTesting