Skip to content

Add typescript types to package exports#192

Closed
jonrouleau wants to merge 1 commit intojamiebuilds:mainfrom
jonrouleau:ts-exports
Closed

Add typescript types to package exports#192
jonrouleau wants to merge 1 commit intojamiebuilds:mainfrom
jonrouleau:ts-exports

Conversation

@jonrouleau
Copy link
Copy Markdown

Fixes #191

@HalfdanJ
Copy link
Copy Markdown

HalfdanJ commented Jan 3, 2024

I ran into the exact same issue, and this solved it perfectly.

@jobjen02
Copy link
Copy Markdown

jobjen02 commented Feb 6, 2024

Please merge this. We cannot deploy due to this issue!!

@alexciesielski
Copy link
Copy Markdown

necessary indeed

@jpzwarte
Copy link
Copy Markdown

Ran into the same thing.

@Regaddi
Copy link
Copy Markdown

Regaddi commented May 3, 2024

I felt smart in attempting to fix this temporarily using patch-package, but apparently one can't easily patch a package's package.json as part of a patch.

⁉️  Not creating patch file for package 'tinykeys'
⁉️  There don't appear to be any changes.

So the only options are:

  • Fork this package
  • Copy the source (400 bytes, right? MIT License, right?)
  • Get this PR merged and published in a new version

@heyitsarpit
Copy link
Copy Markdown

@jamiebuilds please merge this

@jonrouleau jonrouleau closed this by deleting the head repository Dec 17, 2025
@jobjen02
Copy link
Copy Markdown

@jrouleau, why did you close this/ delete the head repository?

@jonrouleau
Copy link
Copy Markdown
Author

@jobjen02 Spring cleaning. Also, there are 5 other PRs for this: #188 #193 #194 #198 #201

@jobjen02
Copy link
Copy Markdown

@jrouleau alright, but does it get merged? It's open for a while now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typescript types not resolving when using tsconfig with moduleResolution: "Bundler"

7 participants