Open
Conversation
Owner
|
I'm not so sure about this one. I think the yellow is a bit ugly. Perhaps a more pale shade would look better? |
Contributor
Author
|
I just grabbed the yellowish equivalent of the blue you used for the progress bar from the Android style guide. |
krayon
pushed a commit
to krayon/android-episodes
that referenced
this pull request
May 3, 2022
…l#23) Add language column to episodes table if it does not exist. Closes jamienicol#22.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't really see the previous favourite stars on some shows with dark banners so this is a suggestion.
I've only tried this on my Galaxy SII which uses drawable-hdpi, so I don't know if the m- and xhdpis look good.
Screens:
