-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: GUI startup with external server + data refresh on server switch #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jamiepine
wants to merge
15
commits into
main
Choose a base branch
from
fix/startup-and-server-switch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,576
−454
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
eb5869e
fix: GUI startup with external server + data refresh on server switch
jamiepine 12ed2d5
Adds a trash icon button alongside the existing retry button for
liorshahverdi e4def93
Merge pull request #321 from liorshahverdi/fix/delete-failed-generati…
jamiepine 3584283
feat: Kokoro 82M TTS engine + voice profile type system
jamiepine 9e726ad
fix: remove engine dropdown filtering — profile grid handles it
jamiepine 0fc2192
fix: resolve relative paths using configured data dir, not CWD
jamiepine d6f48ac
Mirror the regular /generate endpoint behavior more closely
jamiepine a710117
Merge pull request #325 from jamiepine/feat/kokoro-engine
jamiepine d70b878
fix: tighten kokoro profile handling
jamiepine 4e0c731
feat: add Qwen CustomVoice preset engine
jamiepine 72c13fd
fix: enforce preset profile engine compatibility
jamiepine e6f419c
fix: show all engines in floating generator
jamiepine b108bb1
fix: store media paths relative to data dir
jamiepine 8b1c755
Merge remote-tracking branch 'origin/fix/startup-and-server-switch' i…
jamiepine 60aac27
fix: address PR #319 review feedback — health validation, error handl…
jamiepine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing
qwen_custom_voicein the engine type cast.The type assertion on lines 136-142 omits
qwen_custom_voice, which is a validdefault_enginevalue per the backend model. While this won't cause runtime errors, it creates a type inconsistency.🐛 Add the missing engine type
form.setValue( 'engine', selectedProfile.default_engine as | 'qwen' + | 'qwen_custom_voice' | 'luxtts' | 'chatterbox' | 'chatterbox_turbo' | 'tada' | 'kokoro', );🤖 Prompt for AI Agents