fix: include changelog in docker web build#344
fix: include changelog in docker web build#344pandego wants to merge 1 commit intojamiepine:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThese changes modify Docker configuration files to include Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can disable sequence diagrams in the walkthrough.Disable the |
Summary
CHANGELOG.mdin the frontend build contextCHANGELOG.mdfrom the Docker build context in.dockerignoreProblem
docker compose up --build -dwas failing on currentmainduring the frontend build.The Vite changelog plugin reads
CHANGELOG.mdat build time, but the Dockerfile only copiedpackage.json,bun.lock,app/, andweb/into the frontend stage. The build then failed with:Fix
CHANGELOG.mdinto the frontend Docker build stageCHANGELOG.mdfrom.dockerignoreso it is actually available to DockerValidation
maindocker compose up --build -d127.0.0.1:17493GET /healthreturns healthy JSONhttp://127.0.0.1:17493/in the browser and verified the Voicebox UI loadsCloses #308.
Summary by CodeRabbit