Prevent breaking leading xml tag #142
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- As some sites specify leading xml comment tag instead of doctype, xml comment tag should not be broken during parsing of any document - When the comment tag is like <?...?> - simply render it's NodeValue as no more wrapping is required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm using your tool to build a kind of WebGrabber so I have to handle really many cases.
One of them is the html document with " tag instead of DocType.
It's rendered by any modern browser without errors so I expect the same functionality from CSQuery.
However, default output formatter transorms the tag into " which is handled in incorrect way by browsers.
I suggest the following pull request to fix the issue. I'm sorry for having no time to dig deeper to the root cause why described tag is parsed as html comment.
Short commit description:
1)Prevent Default OutputFormatter from breaking leading xml comment
comment tag should not be broken during parsing of any document
no more wrapping is required