This repository was archived by the owner on Dec 24, 2025. It is now read-only.
fix for java version 23 #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbnz
reviewed
Jan 17, 2025
Owner
janbnz
left a comment
janbnz
left a comment
There was a problem hiding this comment.
I think it's a good idea to update to Java 23 but what is the point of disabling the metrics and adding a main class called "com.beginsecure.App" which clearly does not exist?
You also added .idea
Author
|
The metrics didn't work for me so I just comentend them out. The .idea folder I forgot to add to .gitignore and the I forgot the change the class. I guess because it just worked :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.