Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements functionality to write an empty unused messages file when the -u option is provided to the merge command but no unused messages are found. This resolves issue #108 by ensuring that if an unused file previously existed, it will be cleared when there are no more unused messages, rather than leaving the old content in place.
Key Changes
- Modified the merge command logic to always write to the unused file when
-uis specified, creating an empty file when no unused messages exist - Added a test case to verify that an existing unused file is properly cleared when there are no unused messages
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| trubar/main.py | Updated merge command to create an empty unused file when -u is specified but no unused messages exist |
| trubar/tests/shell_tests/merge/test.sh | Added test case to verify empty unused file is written when an existing unused file has content but no unused messages remain |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #108.
When -u is given to merge, an empty file is written if there are not unused messages.