Skip to content

Conversation

@alexbrasetvik
Copy link
Contributor

Depends on jankrib/xcomfort-python#16

(Builds on #31, but couldn't make it the "base" of this PR since the PR is from a fork.)

I'm not sure how to best do the switch integration. It's probably best if they trigger events in addition to their state changes? My physical switches do not display any state as such, and I could imagine that "double clicking" could be turned into something useful with HA.

Haven't had time to properly learn about the event stuff in HA yet.

@alexbrasetvik alexbrasetvik marked this pull request as draft May 5, 2024 22:44
@alexbrasetvik
Copy link
Contributor Author

Changed it to draft. The unique_id generation should include the hub identifier. I have some other changes that's not quite in a reviewable state yet to clean up that deals with that.

@alex-w2
Copy link

alex-w2 commented Sep 28, 2024

@alexbrasetvik Played with this a bit and pulled it into my dev branches. Your switch implementation is definitely nicer than my hack. 👍

However, not sure about the naming, so for now I've changed it back to my variant on my branch here (and also added back the hub id).

@olegje
Copy link

olegje commented Oct 12, 2024

Trying to implement this in my own setup.
Are you using antoher version of xcomfort module?
I get this error on startup both on "live" HA and in dev container:

ImportError: cannot import name 'DoorSensor' from 'xcomfort.devices' (/usr/local/lib/python3.12/site-packages/xcomfort/devices.py)

Complete error: xcomfort_log.log

@alex-w2, @alexbrasetvik Any tips to resolve this? Help is much appreciated :)

@alex-w2
Copy link

alex-w2 commented Oct 18, 2024

@olegje You need an updated version of jankrib/xcomfort-python once jankrib/xcomfort-python#16 gets merged.

Meanwhile you can try and download that version manually, which can be a bit fiddly. I ended up renaming it to a custom name locally and changing all the import statements, probably there might be easier ways.

@alex-w2 alex-w2 mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants