Merged
Conversation
- Make no longer autodetects platform
- for android and darwin you have to specify
- removed platform.h
- Bugfix E.windows init for BSD. Which was causing the segfault
- Resolved various compiler warnings
- Confirmed build without warnings on Oracle Redhat, Alpine, Ubuntu, OSX,
OpenBSD, Slackware.
japanoise
approved these changes
Jul 11, 2025
Owner
japanoise
left a comment
japanoise
left a comment
There was a problem hiding this comment.
Great job! Some minor cleanup here which I'll take care of myself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make androidmakedoes work.The Makefile can be further improved in a future commit: more POSIX compliant would be write "emsys" instead of $(PROGNAME). And may be able to eliminate need for separate build targets per platform. I would want to get it compiling without warnings on AIX first and then the Makefile itself will tell the full story.
What does this change?
Testing done
Did some basic edits like typing , moving cursor, mark, open file, save file.
Yeah Baby!