Skip to content

Sweep: Picker Attribute "SelectedIndex" Not being respected on page load on Android? (✓ Sandbox Passed)#320

Open
sweep-ai-deprecated[bot] wants to merge 3 commits intomainfrom
sweep/picker_attribute_selectedindex_not_being
Open

Sweep: Picker Attribute "SelectedIndex" Not being respected on page load on Android? (✓ Sandbox Passed)#320
sweep-ai-deprecated[bot] wants to merge 3 commits intomainfrom
sweep/picker_attribute_selectedindex_not_being

Conversation

@sweep-ai-deprecated
Copy link
Copy Markdown

PR Feedback (click)

  • 👍 Sweep Did Well
  • 👎 Sweep Needs Improvement

Description

This pull request includes changes to two files: src/Controls/src/Core/Picker/Picker.cs and src/Controls/src/Xaml/XamlNode.cs. The changes address the issue where the SelectedIndex attribute of the Picker control is not being respected on page load on Android.

Summary

  • In src/Controls/src/Core/Picker/Picker.cs:
    • Modified the CoerceSelectedIndex method to check if the Items property is null or empty before coercing the SelectedIndex value.
  • In src/Controls/src/Xaml/XamlNode.cs:
    • Added a new deferredProperties dictionary to store deferred properties.
    • Added a new method DeferProperty to add properties to the deferredProperties dictionary.
    • Added a new method ApplyDeferredProperties to apply the deferred properties to the Properties dictionary.
    • Modified the Accept method to call ApplyDeferredProperties if the visiting mode is TopDown and the node is not skipped.
    • Modified the Clone method to check if the ItemsSource or Items properties are being set and apply deferred SelectedIndex if any.

Fixes #318.


🎉 Latest improvements to Sweep:
  • New dashboard launched for real-time tracking of Sweep issues, covering all stages from search to coding.
  • Integration of OpenAI's latest Assistant API for more efficient and reliable code planning and editing, improving speed by 3x.
  • Use the GitHub issues extension for creating Sweep issues directly from your editor.

💡 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

@sweep-ai-deprecated
Copy link
Copy Markdown
Author

Rollback Files For Sweep

  • Rollback changes to src/Controls/src/Core/Picker/Picker.cs
  • Rollback changes to src/Controls/src/Xaml/XamlNode.cs

This is an automated message generated by Sweep AI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Picker Attribute "SelectedIndex" Not being respected on page load on Android?

1 participant