Add reps support with Epley 1RM estimation#71
Open
jappeace-sloth wants to merge 1 commit intojappeace:masterfrom
Open
Add reps support with Epley 1RM estimation#71jappeace-sloth wants to merge 1 commit intojappeace:masterfrom
jappeace-sloth wants to merge 1 commit intojappeace:masterfrom
Conversation
Record reps alongside weight in PR history and estimate 1RM using the Epley formula (weight * (1 + reps/30)) for multi-rep sets. Storage: - Add reps column (Int32) to PrHistoryT beam schema - Add ALTER TABLE migration for existing databases lacking reps column - Thread reps through saveRecord, loadExerciseHistory, getHistorySince, mergeHistoryEntry, insertHistory UI (Views): - Add reps text input (InputNumber, default 1) on EnterPR screen - Show estimated 1RM when weight and reps > 1 are filled - Display "x N" suffix in history entries when reps > 1 - New estimate1RM and parseReps functions Sync: - Thread reps through sync request/response mapping - Include reps in mergeHistoryEntry dedup Tests: - Update all storage/sync test calls with reps parameter - Add parseReps and estimate1RM unit tests (75 tests pass) Pin pr-sync-api to feature/reps-support with historyReps field. Prompt: implement reps support plan across pr-sync-api, megavid, prrrrrrrrr Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
weight * (1 + reps/30)) for multi-rep setsfeature/reps-supportbranch, thread reps through syncDependencies
historyRepsto shared types)Test plan
cabal buildpassescabal testpasses (75 tests, including new parseReps and estimate1RM tests)nix-build nix/ci.nixpasses🤖 Generated with Claude Code