Add preferences to main app class #99
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredks
reviewed
Dec 10, 2018
Owner
jaredks
left a comment
jaredks
left a comment
There was a problem hiding this comment.
This is cool. I like that it's easier to save data but I wonder now in what circumstance do you use,
app = App('Cool App')
with app.open('data.json') as f:
json.dump({'key': 'value'}, f)
vs.
app = App('Cool App')
app.preferences.set('key', 'value')
Should these concepts not be consolidated?
Also I think we should use serializer rather than hardcode pickle.
| self._preferences[key] = value | ||
| with open(self._path, "wb") as file: | ||
| pickle.dump(self._preferences, file, 2) | ||
| print("Set preference %s to %s" % (key, repr(value))) |
Owner
There was a problem hiding this comment.
Suggested change
| print("Set preference %s to %s" % (key, repr(value))) | |
| _log("Set preference %s to %s" % (key, repr(value))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from https://github.com/laffra/happymac
Provides the methods
self.preferences.getandself.preferences.setto all rumps apps, established in the home directory if no directory is provided.The user can set the preferences to the application folder with the following block in the
__init__function of an app, after a call usingsuper