Fix issue #131 to we use adapter.getItemText() rather than item.toString#149
Open
scottyab wants to merge 3 commits intojaredrummler:masterfrom
Open
Fix issue #131 to we use adapter.getItemText() rather than item.toString#149scottyab wants to merge 3 commits intojaredrummler:masterfrom
scottyab wants to merge 3 commits intojaredrummler:masterfrom
Conversation
scottyab
commented
Jun 4, 2021
scottyab
commented
- Fix issue Selected Item shows with .toString() #131 to we use adapter.getItemText() rather than item.toString.
⚠️ had to remove the Hint text handling as I observed several bugs related to manipulating the size of the adapter, i.e +1 with hint present. For example the spinner would be missing the first item and then would crashing with index out of bounds error on selection of items at end of the list. (Just see how the example app doesn't show Cupcake). This might be somewhat drastic to remove however I was short on time and it's not a feature we use so I removed to simplify.- Update Gradle so project runs
…Text() Remove Hint text as it was screwing up the count/selection listener
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.