fix(numbering): avoid NoneType errors for PDBs with non-Fv chains#1
Open
y1zhou wants to merge 1 commit intojaredsampson:mainfrom
Open
fix(numbering): avoid NoneType errors for PDBs with non-Fv chains#1y1zhou wants to merge 1 commit intojaredsampson:mainfrom
y1zhou wants to merge 1 commit intojaredsampson:mainfrom
Conversation
When the input contains chains that could not be numbered by ANARCI, previous code would first drop entries in the `numbering` list, resulting in a length mismatch between `numbering` and `details`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the input contains chains that could not be numbered by ANARCI, previous code would first drop entries in the
numberinglist, resulting in a length mismatch betweennumberinganddetails. Assuming the input is a three-chain PDB in the order of VH, antigen, and VL, the line:would error with
TypeError: 'NoneType' object is not subscriptablebecause the second chain got removed innumberingin the previous line.