update lib/devtools to set window size and position on initialization#51
Open
starpit wants to merge 2 commits intojaridmargolin:devfrom
Open
update lib/devtools to set window size and position on initialization#51starpit wants to merge 2 commits intojaridmargolin:devfrom
starpit wants to merge 2 commits intojaridmargolin:devfrom
Conversation
this avoids the flashing in the current impl, as the size is set after the window has already opened this also adds the ability for callers to specify the window size, whereas before the height was hardwired
Owner
|
This is definitely better than the current approach. Would like to take the sizing one step further and support #47 I am going to add the options to the CLI and get this merged. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this avoids the flashing in the current impl, as the size is set after the window has already opened
this also adds the ability for callers to specify the window size, whereas before the height was hardwired