Skip to content

Fix: don't escape MD if text is part of URL #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tomyeh wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix: don't escape MD if text is part of URL #51

tomyeh wants to merge 6 commits into from

Conversation

@tomyeh
Copy link
Contributor

@tomyeh tomyeh commented Feb 14, 2025

As shown in the test case, _escape() may prefix _ with \ mistakely for URLs.
I adjusted the regular expression to ignore URLs.

jarontai
jarontai approved these changes Oct 9, 2025
View reviewed changes
Copy link
Owner

@jarontai jarontai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jarontai jarontai jarontai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomyeh @jarontai @jimmyshiau