Fix express-load when using ES6 classes#43
Open
felipeplets wants to merge 2 commits intojarradseers:masterfrom
Open
Fix express-load when using ES6 classes#43felipeplets wants to merge 2 commits intojarradseers:masterfrom
felipeplets wants to merge 2 commits intojarradseers:masterfrom
Conversation
Author
|
Hello @jarradseers , any plans to release a new fix version of express-load with this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @jarradseers,
My team use express-load in a project and was unable to use it together with ES6 classes.
I created the PR and fix it by myself and would be happy if you can check it and release the fix.
Cheers,
Felipe
P.s.: although I see your efforts are on consign now, there are some issues in consign that makes it not work in our environment, I've opened some issues and a PR on consign last year in order to migrate.