Fix .US domain parser & add .JP registrar support #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix .US Domain Parser & Add .JP Registrar Support
This PR includes two important parser fixes:
1. Fix .US Domain Parser for ICANN-Compliant Format
Problem
The
.usdomain parser was failing because it was usingBaseShared2which was designed for the old NeuStar format (pre-2015). The .US registry has since transitioned to Registry Services, LLC and now uses ICANN-compliant WHOIS format.Solution
BaseShared2toBaseIcannCompliant2. Add Registrar Property Support for Japanese (.jp) Domains
Problem
The Japanese (.jp) WHOIS parser was missing registrar information extraction.
Solution
Background
The
.usregistry changed their WHOIS format sometime after 2014:Old format (NeuStar, pre-2015):
New format (Registry Services LLC, current):
Changes
BaseIcannCompliantbase classstatusproperty returns EPP codes as array:["clientDeleteProhibited", "serverTransferProhibited"]Verification
Tested with multiple .us domains, all return ICANN-compliant format:
References