Shrinking the image #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al docker image size. Therefore also excluded the cntlm sources from this repo. Instead the cntlm sources are loaded when building the docker image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I appreciate your work for providing a docker container with a ready build cntlm. I'm using it now for almost 9 months. Though I think with 226 MB the container is a little on the heavy side in terms of image size on the file system.
Therefore I went and tried to reduce the size of the image a little bit and ended up with 13 MB for the image.
If you want to checkout the smaller image you can access my forked version on docker hub https://hub.docker.com/r/protenhan/docker-cntlm/. If you think about merging my pull request then I would be glad to remove my image from docker hub.
Best regards
Phillipp