Split large memory accesses in stack alloc#741
Draft
sarranz wants to merge 2 commits intojasmin-lang:mainfrom
Draft
Split large memory accesses in stack alloc#741sarranz wants to merge 2 commits intojasmin-lang:mainfrom
sarranz wants to merge 2 commits intojasmin-lang:mainfrom
Conversation
Contributor
|
opam strikes back. You used a feature (symmetry of disequality) that is not available before Coq 8.18 (cf. rocq-prover/rocq#17025), and opam tests 8.16. The stupid fix is to call a lemma instead of symmetry, but maybe it is time to increase the lowest supported version to 8.18? |
Collaborator
Author
|
I will use the lemma, thanks! |
sarranz
force-pushed
the
stack-alloc-split-mem-op
branch
from
6f36509 to
8585a1c
Compare
bgregoir
previously approved these changes
Mar 13, 2024
Contributor
bgregoir
left a comment
bgregoir
left a comment
There was a problem hiding this comment.
I strongly suspect that we will have to wrote the same code for risc-V.
So maybe we should take the time to make the code a little bit more modular.
sarranz
force-pushed
the
stack-alloc-split-mem-op
branch
from
8585a1c to
d6f0923
Compare
bgregoir
reviewed
Mar 20, 2024
sarranz
force-pushed
the
stack-alloc-split-mem-op
branch
from
d6f0923 to
8b37b53
Compare
sarranz
force-pushed
the
stack-alloc-split-mem-op
branch
from
8b37b53 to
3a4a8b4
Compare
sarranz
force-pushed
the
stack-alloc-split-mem-op
branch
from
67d3750 to
4011b7e
Compare
Collaborator
Author
|
I'll try and update this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When stack allocation replaces
x = eby[rsp + off] = e, the offset may be too large. I introduced a check at everyCopnthat splits this memory access into several instructions in ARM. I also added a warning. Note that whenxis an array set, this can be fixed manually withreg ptrs, but if it's a variable there's no way of doing so (but this scenario is probably far-fetched).