Skip to content

fix(guidance): Stop button drops taps because render() rebuilds it on every GPS fix (#179) #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasoneplumb merged 1 commit into from
Apr 26, 2026
Merged

fix(guidance): Stop button drops taps because render() rebuilds it on every GPS fix (#179) #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/guidance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,11 @@ export function addGuidanceControl(
panelEl = c;
L.DomEvent.disableClickPropagation(c);
L.DomEvent.disableScrollPropagation(c);
// Delegate clicks on .guidance-btn to a single persistent listener so
// every-GPS-fix re-renders don't destroy the button mid-tap.
L.DomEvent.on(c, 'click', (e: Event) => {
if ((e.target as HTMLElement).closest('.guidance-btn')) onStop();
});
render();
return c;
},
Expand Down Expand Up @@ -386,10 +391,11 @@ function render(): void {
function appendButton(label: string, modifier: string, ariaLabel: string): void {
if (!panelEl) return;
const btn = document.createElement('button');
btn.type = 'button';
btn.className = `guidance-btn ${modifier}`;
btn.textContent = label;
btn.setAttribute('aria-label', ariaLabel);
btn.addEventListener('click', onStop);
// Click handling lives on panelEl via delegation — see addGuidanceControl.
panelEl.appendChild(btn);
}

Expand Down
Loading